Clarify package token value editing - #564

packages/worker/client/routes/account-package-invocation-tokens.tsx (1)

1270-1401: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Duplicate raw token input in the edit form — the old "Replace raw token" block was not removed.

The PR adds the new "Token value" section (Lines 1327-1401) but the prior "Replace raw token" field (Lines 1270-1325) is still present in the same isEditingSelectedToken form. The edit form now renders two identical name="rawToken" password inputs, each with its own Generate/Copy buttons and helper text, both bound to editorState.rawToken.

This contradicts the PR intent (the new section was meant to replace the old layout) and produces a confusing UI with duplicated labels and controls. Remove the old block so only the "Token value" section remains.

🐛 Proposed fix: remove the old "Replace raw token" block

-									<label mix={css(fieldCss)}>
-										<span mix={css(fieldLabelCss)}>Replace raw token</span>
-										<div
-											mix={css({
-												display: 'grid',
-												gridTemplateColumns: 'minmax(0, 1fr) auto auto',
-												gap: spacing.sm,
-												[mq.mobile]: {
-													gridTemplateColumns: '1fr',
-												},
-											})}
-										>
-											<input
-												name="rawToken"
-												type="password"
-												value={editorState.rawToken}
-												placeholder="Leave blank to keep the current token value"
-												autoComplete="off"
-												disabled={isMutating}
-												mix={[
-													on('input', (event) => {
-														setEditorField(
-															'rawToken',
-															event.currentTarget.value,
-														)
-														handle.update()
-													}),
-													css(inputCss),
-												]}
-											/>
-											<button
-												type="button"
-												disabled={isMutating}
-												mix={[
-													on('click', generateEditorRawToken),
-													css(secondaryButtonCss),
-												]}
-											>
-												Generate
-											</button>
-											<button
-												type="button"
-												disabled={isMutating || !editorState.rawToken}
-												mix={[
-													on('click', () => void copyEditorRawToken()),
-													css(secondaryButtonCss),
-												]}
-											>
-												Copy
-											</button>
-										</div>
-										<span mix={css(descriptionCss)}>
-											Paste or generate a new raw token only when rotating this
-											credential. Kody stores only its hash.
-										</span>
-									</label>
-
 									<div
 										mix={css({
 											display: 'grid',
 											gap: spacing.sm,

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/worker/client/routes/account-package-invocation-tokens.tsx` around
lines 1270 - 1401, The edit form currently renders two raw token inputs because
the old “Replace raw token” block is still present alongside the new “Token
value” section. In the `isEditingSelectedToken` form, remove the earlier
`rawToken` label/input/button group and keep only the new `Token value` section
so there is a single `editorState.rawToken` field with one set of Generate/Copy
controls.